Skip to content

Adopt core MCP semconv bucket preset in telemetry - #6144

Merged
rdimitrov merged 2 commits into
mainfrom
chore/use-core-mcp-semconv-buckets
Jul 30, 2026
Merged

Adopt core MCP semconv bucket preset in telemetry#6144
rdimitrov merged 2 commits into
mainfrom
chore/use-core-mcp-semconv-buckets

Conversation

@JAORMX

@JAORMX JAORMX commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Source pkg/telemetry.MCPHistogramBuckets from toolhive-core/telemetry/metrics.BucketsMCPSemconv() instead of a locally-defined literal. Callers (pkg/vmcp/..., pkg/ratelimit) are untouched — the exported var keeps the same name and value set.

Bumps toolhive-core to v0.0.36, which contains the preset (stacklok/toolhive-core#202, merged).

Test plan

  • task build, task lint-fix — clean
  • go test ./pkg/telemetry/... ./pkg/vmcp/server/sessionmanager/... ./pkg/vmcp/internal/backendtelemetry/... ./pkg/vmcp/core/... ./pkg/ratelimit/... — all pass

@github-actions github-actions Bot added the size/XS Extra small PR: < 100 lines changed label Jul 30, 2026
@JAORMX
JAORMX marked this pull request as ready for review July 30, 2026 11:34
@github-actions github-actions Bot added size/XS Extra small PR: < 100 lines changed and removed size/XS Extra small PR: < 100 lines changed labels Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.58%. Comparing base (3d44435) to head (5141c59).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6144      +/-   ##
==========================================
- Coverage   72.63%   72.58%   -0.06%     
==========================================
  Files         736      736              
  Lines       76355    76355              
==========================================
- Hits        55463    55423      -40     
- Misses      16955    17009      +54     
+ Partials     3937     3923      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rdimitrov
rdimitrov merged commit 247480f into main Jul 30, 2026
49 checks passed
@rdimitrov
rdimitrov deleted the chore/use-core-mcp-semconv-buckets branch July 30, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants