Adopt core MCP semconv bucket preset in telemetry - #6144
Merged
Conversation
JAORMX
marked this pull request as ready for review
July 30, 2026 11:34
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6144 +/- ##
==========================================
- Coverage 72.63% 72.58% -0.06%
==========================================
Files 736 736
Lines 76355 76355
==========================================
- Hits 55463 55423 -40
- Misses 16955 17009 +54
+ Partials 3937 3923 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rdimitrov
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source
pkg/telemetry.MCPHistogramBucketsfromtoolhive-core/telemetry/metrics.BucketsMCPSemconv()instead of a locally-defined literal. Callers (pkg/vmcp/...,pkg/ratelimit) are untouched — the exported var keeps the same name and value set.Bumps
toolhive-coreto v0.0.36, which contains the preset (stacklok/toolhive-core#202, merged).Test plan
task build,task lint-fix— cleango test ./pkg/telemetry/... ./pkg/vmcp/server/sessionmanager/... ./pkg/vmcp/internal/backendtelemetry/... ./pkg/vmcp/core/... ./pkg/ratelimit/...— all pass