Parse multi-line Modern SSE events - #6126
Open
kocaemre wants to merge 1 commit into
Open
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
kocaemre
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
jerm-dro,
jhrozek and
tgrunnagle
as code owners
July 28, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data:line as a standalone JSON-RPC envelope, but the SSE spec defines one event as alldata:lines up to the blank-line boundary joined with\n.data:lines could be misread as not-Modern and fall back to Legacy.readModernSSEto accumulate one SSE event at a time, join multi-linedata:fields, ignore interleaved server-to-client messages, and flush the final event even without a trailing blank line.data:, CRLF line endings, interleaved notifications, and EOF without a trailing blank line.Fixes #6102
Type of change
Test plan
task test)task test-e2e)task lint-fix)Manual testing:
PATH=/usr/local/go/bin:/root/go/bin:$PATH go test ./pkg/vmcp/client -run TestModernCall_SSEResponsefailed onmulti-line data responsewithbackend response is not a Modern (2026-07-28) MCP response.PATH=/usr/local/go/bin:/root/go/bin:$PATH go test ./pkg/vmcp/client -run TestModernCall_SSEResponsePATH=/usr/local/go/bin:/root/go/bin:$PATH go test ./pkg/vmcp/client -run 'TestModernCall_SSEResponse|TestModernCall_ErrorMapping|TestModernCall_Decode'PATH=/usr/local/go/bin:/root/go/bin:$PATH go test -race ./pkg/vmcp/client -run TestModernCall_SSEResponsePATH=/usr/local/go/bin:/root/go/bin:$PATH go test ./pkg/vmcp/clientPATH=/usr/local/go/bin:/root/go/bin:$PATH task lintgit diff --checkI also ran
PATH=/usr/local/go/bin:/root/go/bin:$PATH task test. It failed in unrelated packages (cmd/thv/app,pkg/client, andpkg/skills/skillsvc) outside this PR's two touched files, including a panic inpkg/client/config_test.go; the targetedpkg/vmcp/clientpackage and lint checks above passed.API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Does this introduce a user-facing change?
No direct user-facing CLI/API change. It fixes vMCP's backend revision detection for conformant Modern streamable-HTTP servers that split SSE
data:fields.Special notes for reviewers
The parser keeps the existing behavior of only returning the response matching the JSON-RPC id requested by
modernCall; server-to-client requests/notifications and other response ids are still ignored.