Use conformant Accept in dual-era e2e - #6123
Open
kocaemre wants to merge 1 commit into
Open
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
kocaemre
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
aponcedeleonch,
jhrozek,
rdimitrov and
reyortiz3
as code owners
July 28, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept: application/json, text/event-streamheader that both MCP revisions require.WithStreamableAccept()to the vMCP dual-era bridge and concurrent-mixing specs so those proxy paths now run under conformant request headers.Fixes #6104
Type of change
Test plan
task test)task test-e2e)task lint-fix)Manual testing:
PATH=/usr/local/go/bin:/root/go/bin:$PATH go test ./test/e2e -run 'TestRawClientBuilders/no_Accept|TestRawClientSSEResponse'PATH=/usr/local/go/bin:/root/go/bin:$PATH go test -race ./test/e2e -run 'TestRawClientBuilders/no_Accept|TestRawClientSSEResponse'PATH=/usr/local/go/bin:/root/go/bin:$PATH task buildPATH=/usr/local/go/bin:/root/go/bin:$PATH THV_BINARY=$PWD/bin/thv TOOLHIVE_DEV=true TEST_TIMEOUT=15m LABEL_FILTER='vmcp && dual-era' ./test/e2e/run_tests.sh— 7 passed, 0 failed, 500 skippedPATH=/usr/local/go/bin:/root/go/bin:$PATH task lintgit diff --checkNote: I also tried
go test ./test/e2ebefore exportingTHV_BINARY; it failed because the full e2e suite could not findthvon$PATH. The labeled e2e run above used the freshly builtbin/thvand passed.API Compatibility
v1beta1API, OR theapi-break-allowedlabel is applied and the migration guidance is described above.Changes
test/e2e/vmcp_dual_era_test.gotest/e2e/dual_era_mixing_test.gotest/e2e/mcp_raw_client.gotest/e2e/mcp_raw_client_test.goDoes this introduce a user-facing change?
No.
Special notes for reviewers
The production behavior is unchanged. This only flips test traffic to the spec-required Accept header now that RawMCPClient can parse SSE-framed POST responses.