Rules: say who runs /code-review, and what to do when nobody can - #33
Merged
Conversation
Step 2 of the review loop read 'Run /code-review against the resulting diff', phrased as an instruction to the agent. It isn't one an agent can follow: /code-review is user-invoked and billed to the user, and cannot be launched through the Skill tool, Bash, or any workaround. An agent reading the rule literally either stalls or quietly skips the step, and skipping it silently is the worse of the two. Split step 2 by who is present. Working synchronously, the agent prompts the user to run it and says which tier the change warrants -- that path is preferred, since it is the real thing and the user decides what merges anyway. Running autonomously, the agent approximates with independent reviewer subagents plus the adversarial binary run, which needs no slash command, and must not describe the approximation as if /code-review had run. The tier names in 'Scale round one' were written as /code-review arguments, so they now name the depth itself: the argument when the user runs it, the number of finder angles when approximating. Round records say which path was taken. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Joe Beda <joe@stacklok.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.claude/rules/agent-workflow.mdstep 2 said "Run/code-reviewagainst the resulting diff" — phrased as an instruction to the agent, which is not one an agent can follow./code-reviewis user-invoked and billed to the user; it cannot be launched through the Skill tool, Bash, or any workaround.An agent reading that rule literally either stalls waiting to run something it can't, or quietly skips the step. Silent skipping is the worse failure, because the loop's whole purpose is that correctness-critical changes don't ship unreviewed.
What changed
Step 2 now splits by who is present.
/code-reviewran.Tier names stop being slash-command arguments.
highandmediumnow name the depth itself — the argument when the user runs it, the number of finder angles when approximating — so the section reads correctly on both paths.Round records say which path was taken, alongside the existing requirement to attribute each finding to its source.
An approximated round is also called out as grounds to keep a PR in draft when the change is correctness-critical and the user hasn't looked yet.
Notes
task checkgreen.🤖 Generated with Claude Code