feat(sqlserverflex): refactor wait handler to use helper struct#7448
Open
GokceGK wants to merge 3 commits into
Open
feat(sqlserverflex): refactor wait handler to use helper struct#7448GokceGK wants to merge 3 commits into
GokceGK wants to merge 3 commits into
Conversation
relates to STACKITSDK-394
relates to STACKITSDK-394
Fyusel
reviewed
May 28, 2026
| return *response.Item.Status, nil | ||
| }, | ||
| ActiveState: []string{InstanceStateSuccess}, | ||
| ErrorState: []string{InstanceStateUnknown, InstanceStateFailed, InstanceStateEmpty}, |
Contributor
There was a problem hiding this comment.
Need to adjust to new structure (enum change)
| switch strings.ToLower(*s.Item.Status) { | ||
| case strings.ToLower(InstanceStateSuccess): | ||
| return true, s, nil | ||
| case strings.ToLower(InstanceStateUnknown), strings.ToLower(InstanceStateFailed): |
Contributor
There was a problem hiding this comment.
Hm, what about this "toLower" here? Is this based on an API issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITSDK-394
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)