Skip to content

feat(albwaf): onboard albwaf custom rule group - #1533

Draft
SerseusWasTaken wants to merge 1 commit into
mainfrom
feat/add-waf-custom-rule-group
Draft

feat(albwaf): onboard albwaf custom rule group#1533
SerseusWasTaken wants to merge 1 commit into
mainfrom
feat/add-waf-custom-rule-group

Conversation

@SerseusWasTaken

Copy link
Copy Markdown
Contributor

Description

Adds albwaf custom rule group support

Relates to STACKITCLI-443

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@SerseusWasTaken
SerseusWasTaken force-pushed the feat/add-waf-custom-rule-group branch from 530c3a3 to 1ad2141 Compare August 13, 2026 13:41
@SerseusWasTaken
SerseusWasTaken force-pushed the feat/add-waf-custom-rule-group branch from 1ad2141 to 9d59902 Compare August 13, 2026 13:53
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/create 51.16% (+51.16%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/delete 32.26% (+32.26%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/describe 79.17% (+79.17%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/generate-payload 50.00% (+50.00%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/list 29.17% (+29.17%) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/update 52.27% (+52.27%) 🌟
github.com/stackitcloud/stackit-cli/internal/pkg/config 70.21% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/albwaf/client 0.00% (ø)
github.com/stackitcloud/stackit-cli/internal/pkg/services/albwaf/utils 100.00% (+100.00%) 🌟

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/albwaf.go 0.00% (ø) 4 (+4) 0 4 (+4)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/create/create.go 51.16% (+51.16%) 43 (+43) 22 (+22) 21 (+21) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/custom-rule-group.go 0.00% (ø) 9 (+9) 0 9 (+9)
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/delete/delete.go 32.26% (+32.26%) 31 (+31) 10 (+10) 21 (+21) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/describe/describe.go 79.17% (+79.17%) 72 (+72) 57 (+57) 15 (+15) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/generate-payload/generate_payload.go 50.00% (+50.00%) 40 (+40) 20 (+20) 20 (+20) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/list/list.go 29.17% (+29.17%) 72 (+72) 21 (+21) 51 (+51) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/update/update.go 52.27% (+52.27%) 44 (+44) 23 (+23) 21 (+21) 🌟
github.com/stackitcloud/stackit-cli/internal/cmd/beta/beta.go 0.00% (ø) 11 (+1) 0 11 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/config/config.go 90.91% (ø) 66 60 6
github.com/stackitcloud/stackit-cli/internal/pkg/services/albwaf/client/client.go 0.00% (ø) 1 (+1) 0 1 (+1)
github.com/stackitcloud/stackit-cli/internal/pkg/services/albwaf/utils/utils.go 100.00% (+100.00%) 8 (+8) 8 (+8) 0 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/delete/delete_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/describe/describe_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/generate-payload/generate_payload_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/list/list_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/beta/albwaf/custom-rule-group/update/update_test.go
  • github.com/stackitcloud/stackit-cli/internal/pkg/services/albwaf/utils/utils_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant