migrate mcm-provider from openstack to stackit - #272
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
size/L
67e72b1 to
dcf82cb
Compare
ske-prow
Bot
added
the
needs-rebase
b696375 to
25fa93d
Compare
ske-prow
Bot
removed
the
needs-rebase
|
/retest-required |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/test pull-gardener-extension-provider-stackit-dev-artifacts |
|
/test all |
81f51f4 to
af6bcea
Compare
|
/test pull-gardener-extension-provider-stackit-integration-tests |
| openStackProviderIDPattern = regexp.MustCompile(`^openstack:///[^/]+/([^/]+)$`) | ||
| stackitProviderIDPattern = regexp.MustCompile(`^stackit://[^/]+/([^/]+)$`) |
There was a problem hiding this comment.
no this should be within func init() so it only runs once
There was a problem hiding this comment.
I dont get the init() func, I have removed this vars and put them in a helper func all together.
| ) | ||
| } | ||
| // capture server ID from provider ID | ||
| serverID := matches[1] |
There was a problem hiding this comment.
somehow this is even more confusing. Can we do named capture groups in the regex?
There was a problem hiding this comment.
I dont get it, do you mean something like regexp.MustCompile(^openstack:///[^/]+/(?P<serverID>[^/]+)$) ?
# Conflicts: # pkg/controller/worker/machines.go
b636923 to
a712745
Compare
2 participants
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR replaces mcm provider from openstack to stackit. Replaces openstack provider ID with stackit provider ID and add
stackit.cloud/migrated-machine: trueannotation to machines and puts annotationstackit.cloud/machine-controller-manager-migrated: trueto workers once the migration is done.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: