Skip to content

fix(Deck): reset build ceiling when applying synced slide state #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chinesepowered wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(Deck): reset build ceiling when applying synced slide state #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/deck/Deck.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,14 @@ export default function Deck({ children }: { children: ReactNode }) {
c.onmessage = (e) => {
if (e.data?.type === 'state') {
applyingRemote.current = true;
setSlide(e.data.slide);
const s = e.data.slide;
setSlide(s);
setClicks(e.data.clicks);
// mirror go(): reset the build ceiling for the incoming slide. Without
// this the synced tab carries the previous slide's curMax forward
// (registerMax only ever raises it), leaving hasNext/hasPrev and the
// nav arrows wrong after the presenter jumps between slides.
setCurMax(Math.max(maxMap.current[s] || 0, e.data.clicks));
}
};
return () => c.close();
Expand Down