Skip to content

feat: [v2] Use a safe type for env override names - #1262

Open
siegfriedweber wants to merge 3 commits into
mainfrom
feat/smooth-operator/safe-env-overrides
Open

feat: [v2] Use a safe type for env override names#1262
siegfriedweber wants to merge 3 commits into
mainfrom
feat/smooth-operator/safe-env-overrides

Conversation

@siegfriedweber

@siegfriedweber siegfriedweber commented Aug 13, 2026

Copy link
Copy Markdown
Member

Description

Use a safe type for env override names

env_overrides in v2::role_utils::CommonConfiguration is now the new v2::env_overrides::EnvOverrides type (a BTreeMap<EnvVarName, String>) instead of a HashMap<String, String>, so environment variable names are validated on deserialization and kept in a deterministic order. v2::role_utils now defines its own CommonConfiguration, Role and RoleGroup instead of re-exporting them from crate::role_utils.

Example: stackabletech/hive-operator#748

Part of stackabletech/internal-issues#167

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@siegfriedweber siegfriedweber self-assigned this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant