Skip to content

feat: better startup and readiness probes - #976

Merged
razvan merged 15 commits into
mainfrom
worktree-nifi-2x-health-probes
Aug 12, 2026
Merged

feat: better startup and readiness probes#976
razvan merged 15 commits into
mainfrom
worktree-nifi-2x-health-probes

Conversation

@razvan

@razvan razvan commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixes #946
Fixes #521

✅ Successfully tested on OKD.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

razvan and others added 9 commits August 10, 2026 14:30
@razvan @claude
feat: add exec-based NiFi 2.x management-server probe builders
2eefa4a 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@razvan
feat: gate NiFi startup/readiness on management-server health endpoints
51bdfa7
@razvan @claude
feat: pin NiFi management-server address explicitly via JVM property
236210b 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@razvan
test: assert NiFi 2.x management-server probes and readiness gating i…
e67829a 
…n cluster_operation kuttl test
@razvan @claude
fix: set explicit timeout_seconds on management-server exec probes
c5ba5fc 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@razvan
fix: revert retry-unsafe NotReady polling assertion in cluster_operat…
2a8df57 
…ion kuttl test
@razvan @claude
fix: increase probe timeout_seconds from 3 to 5 for real headroom
cf041f0 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@razvan
docs: changelog entry for NiFi 2.x management-server health probes
63267ee
@razvan @claude
refactor: relocate MANAGEMENT_SERVER_PORT, document override caveat, …
88a8f27 
…drop dead readiness delay

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@razvan razvan self-assigned this Aug 10, 2026
@razvan
razvan marked this pull request as ready for review August 10, 2026 15:41
@razvan razvan moved this to Development: Waiting for Review in Stackable Engineering Aug 11, 2026
NickLarsenNZ
NickLarsenNZ reviewed Aug 11, 2026
View reviewed changes
Comment thread rust/operator-binary/src/controller/build/properties/bootstrap_conf.rs
@razvan
razvan requested a review from NickLarsenNZ August 11, 2026 13:14
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 12, 2026
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should probably add a release-note (which needs a scheduled-for label, or release/ label).

Comment thread rust/operator-binary/src/controller/build/resource/probes.rs Outdated
Comment thread CHANGELOG.md Outdated
@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 12, 2026
@razvan @NickLarsenNZ
Update CHANGELOG.md
e6a7942 
Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
NickLarsenNZ
NickLarsenNZ approved these changes Aug 12, 2026
View reviewed changes

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@razvan

razvan commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

Release Note

The operator now uses the Nifi health api endpoints for startup and readiness probes. This increases the stability of Nifi installations and makes them more resilient against minimal transient incidents.

@razvan razvan added release-note Denotes a PR that will be considered when it comes time to generate release notes. scheduled-for/26.11.0 labels Aug 12, 2026
@razvan
razvan added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit 8cdd096 Aug 12, 2026
18 checks passed
@razvan
razvan deleted the worktree-nifi-2x-health-probes branch August 12, 2026 08:25
@NickLarsenNZ NickLarsenNZ moved this from Development: In Review to Development: Done in Stackable Engineering Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@razvan razvan

Labels

release/26.11.0 release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

Stackable Engineering
Status: Development: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve startup- & readiness probes for NiFi 2.x Fix health-check to check actual health

2 participants

@razvan @NickLarsenNZ