Skip to content

chore(deps): remove 4 advisory ignore entries that no longer match Cargo.lock - #1752

Open
zyl71 wants to merge 1 commit into
stackabletech:mainfrom
zyl71:remove-stale-advisory-ignores
Open

zyl71 wants to merge 1 commit into
stackabletech:mainfrom
zyl71:remove-stale-advisory-ignores

Conversation

@zyl71

@zyl71 zyl71 commented Nov 21, 2026

Copy link
Copy Markdown

Closes #1751

Description

deny.toml still ignores the advisories below, but Cargo.lock on main either already holds a patched version of the affected crate or no longer contains the crate, so the entries no longer suppress anything. This pull request removes them, together with the comments that explained them.

Advisory Summary In Cargo.lock now Patched in Severity
RUSTSEC-2023-0071 Marvin Attack: potential key recovery through timing sidechannels rsa: not present 0.10.0 medium
RUSTSEC-2026-0097 Rand is unsound with a custom logger using rand::rng() rand 0.10.3 0.8.6, 0.9.3, 0.10.1 low
RUSTSEC-2024-0436 paste - no longer maintained paste: not present – unmaintained
RUSTSEC-2026-0173 proc-macro-error2 is unmaintained proc-macro-error2: not present – unmaintained

Why remove them. An ignore entry keeps muting the advisory id for as long as it stays in the file. If the crate were later pinned back to an affected version or came back into the lock file, cargo-deny would stay silent about it.

What was checked, and what was not.

  • Read from main at commit 0b0a7b008472 on 2026-11-21: each id is on an active line of the config, and no version of the affected crate in Cargo.lock is inside the affected range of its advisory (RustSec records).
  • The change touches only deny.toml. No Rust source and no lock file is changed. The edited file parses as TOML, and every other ignore entry and setting is unchanged.
  • We did not run cargo deny check advisories locally, because we do not build or execute anything from this repository. CI is the first run of the tool on this change.

Not part of this change, but possibly useful: cargo-deny reports such entries as advisory-not-detected warnings, and unused-ignored-advisory = "deny" under [advisories] turns them into errors.

Disclosure: the check, the edit and this text were produced with automated tooling, including an LLM.

Feel free to close this if it is not useful.

Definition of Done Checklist

Not run locally. See the description for what was checked and what was not.

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully

@stackable-cla

stackable-cla Bot commented Nov 21, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 advisory ignore entries no longer match anything in Cargo.lock

1 participant