Allow formatting semantically invalid source - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The Task 8 formatter contract requires syntactically valid source with semantic errors to remain formattable. The initial canonical formatter specification incorrectly described every compiler-stage error as a formatting failure, which conflicts with diagnostic-preserving editor and CLI workflows.
Implementation
Testing
python3 scripts/validate-compiler-diagnostics.pypython3 scripts/validate-formatter-fixtures.pygit diff --checkReview focus / concerns
This is a contract correction only; canonical bytes and existing fixtures do not change. Successful formatting still does not claim semantic validity.