Integrate the expanded core icon catalog - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
stack-sh/theme0.4.0 now provides 30 provider-neutral explicit icons at merged revision2347315e6e86ab9d2708e05fd3f9b5f3d87e1241. Engine must embed that final provider revision before Web can consume the expanded catalog through a released browser package.Implementation Approach
stack-engine,stack-engine-wasm, and@stack-sh/engineto 0.5.0apiicon to the newly addedgatewayiconsha256:9cb3de8b504acbf22c93cea5fbea66be50f38734dc1dee18b9cab7084082cc1fTesting Approach
wasmtimeis not installed on this host; PR CI installs the pinned runtime and is the authoritative cross-target gateReview Perspectives / Points of Concern