Release actionable diagnostics in engine 0.2.0 - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Stack Web and future editor consumers need compiler-owned expected values and guidance at the browser boundary. The engine package must preserve the newly merged compiler diagnostic contract without requiring consumers to reconstruct it.
実装方法
stack-compilerto merged commit3d2379483da1edaeb24a26d43743587a4f5bd645and the specification suite to7f9154d22702ddf02f2713bbc06dde7bdf635806.expectedvalues through native engine diagnostics, serializable WASM diagnostics, JavaScript objects, and generated TypeScript declarations.direction hoofixture that verifies exact range, expected values, help, empty related information, and native/WASM parity.0.2.0, update SVG metadata snapshots, package documentation, and dependency provenance.テスト方法
cargo +stable fmt --checkcargo +stable test --workspace --lockedpython3 scripts/validate-svg.pynpm run build:wasm && npm test && npm run typecheck && npm run pack:checkcargo +stable clippy --workspace --all-targets --all-features --locked -- -D warningsRUSTDOCFLAGS="-D warnings" cargo +stable doc --workspace --no-deps --lockedReview 視点 / 懸念点
This is a minor-version public package change because
Diagnosticgains a requiredexpectedarray. Renderer-owned warnings intentionally emit an empty array. Local WASI parity could not run because Wasmtime is not installed on this host; the unchanged CI job installs Wasmtime 48.0.1 and remains the release gate.