Fix npm release verification - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
The
v0.1.0release workflow rebuilt and tested the browser package successfully, but its package-content audit failed before the registry check. npm 12 changednpm pack --json --workspacefrom an array to an object keyed by workspace name, while the validator only accepted the npm 11 shape.実装方法
テスト方法
npm run pack:checkwith npm 11.5.1npm run pack:checkwith npm 12.0.2npm testnpm run typecheckgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 .github/workflows/release.yamlReview 視点 / 懸念点
The existing public
v0.1.0tag remains unchanged. After this pull request is merged, the manual recovery path will re-run the release checks against that exact tag; because@stack-sh/engine@0.1.0already exists, it must not publish a duplicate version.