Add actionable compiler diagnostics - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Stack consumers need compiler-owned correction guidance so Web and future editors can explain source errors without duplicating language semantics. The specification now requires ordered
expectedvalues and provides canonical actionable-diagnostic fixtures.実装方法
expectedvalues to the public diagnostic model with an empty default.7f9154d22702ddf02f2713bbc06dde7bdf635806and compareexpectedonly when a canonical fixture opts in.テスト方法
cargo +stable fmt --checkcargo +stable testSTACK_SPECIFICATION_DIR=../specification cargo +stable test --features conformance --test conformancecargo +stable clippy --all-targets --all-features -- -D warningsRUSTDOCFLAGS="-D warnings" cargo +stable doc --no-depscargo +stable llvm-cov --lib --all-features --workspace --fail-under-lines 95 --fail-under-functions 95 --fail-under-regions 95cargo +1.85.0 testcargo +1.85.0 clippy --all-targets --all-features -- -D warningsReview 視点 / 懸念点
The diagnostic representation is additive but public. Identifier suggestions intentionally use the specification threshold and never exceed three results. Human-readable wording is not a compatibility contract; structured expected values are exact only where conformance fixtures opt in.