Pin the semantic-error formatter contract - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The canonical formatter specification now permits syntactically valid source with semantic errors to be formatted while preserving its portable diagnostic-code set. The compiler must record the final merged specification revision before the engine consumes both contracts.
Implementation
Update
tests/specification-revisionto the final specification squash commitf382069928c805fe69b7a192bfd6a877036bc036. No compiler implementation changes are required.Testing
cargo +stable fmt --checkcargo +stable testgit diff --checkReview focus / concerns
This PR changes only the immutable specification pin. Compiler schemas, diagnostics, AST, normalized IR, lossless tokens, and source maps are unchanged.