Add an engine-facing source map sidecar - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Task 7 needs post-compiler layout, icon, and theme diagnostics to resolve back to authored Stack ranges without adding source locations to portable normalized IR. Omitted defaults also need to remain distinct from unknown semantic identities.
Implementation
compile_with_source_mapandcompile_bytes_with_source_mapas additive mapped compilation APIsSourceOriginorderstatements from the keyword through the closing bracket, including intervening comments/triviaTesting
cargo +stable fmt --checkcargo +stable test(38 unit tests, 6 integration tests)STACK_SPECIFICATION_DIR=../specification cargo +stable test --features conformance --test conformancecargo +stable clippy --all-targets --all-features -- -D warningsRUSTDOCFLAGS="-D warnings" cargo +stable doc --no-depscargo +stable llvm-cov --lib --all-features --workspace --fail-under-lines 95 --fail-under-functions 95 --fail-under-regions 95(97.90% regions, 99.13% functions, 98.60% lines)cargo +1.85.0 testcargo +1.85.0 clippy --all-targets --all-features -- -D warningsgit diff --checkReview focus / concerns
STK4001diagnosticsSourceOrigin::Omitted, while a lookup for an unknown node/group returnsNone