Add a lossless source model - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Task 6 needs compiler-owned comment and trivia handling before the formatter is implemented. The existing AST keeps decoded syntax values and the normalized IR intentionally excludes formatting data, while the lexer previously discarded whitespace and comments.
Implementation
parse_losslessandparse_lossless_bytesentry points for syntactically valid Stack sourcee40ad5dc230ab58f8a211130af96ae09c0e523bcTesting
cargo +stable fmt --checkcargo +stable test(35 unit tests, 5 integration tests)STACK_SPECIFICATION_DIR=../specification cargo +stable test --features conformance --test conformancecargo +stable clippy --all-targets --all-features -- -D warningsRUSTDOCFLAGS="-D warnings" cargo +stable doc --no-depscargo +stable llvm-cov --lib --all-features --workspace --fail-under-lines 95 --fail-under-functions 95 --fail-under-regions 95(97.92% regions, 98.98% functions, 98.71% lines)cargo +1.85.0 testcargo +1.85.0 clippy --all-targets --all-features -- -D warningsgit diff --checkReview focus / concerns