Skip to content

Do not leak memory when reading FTP CWD responses#2445

Closed
rousskov wants to merge 1 commit into
squid-cache:masterfrom
measurement-factory:SQUID-111-CWD-leak
Closed

Do not leak memory when reading FTP CWD responses#2445
rousskov wants to merge 1 commit into
squid-cache:masterfrom
measurement-factory:SQUID-111-CWD-leak

Conversation

@rousskov

@rousskov rousskov commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The bug affected a subset of HTTP transactions with ftp:// URLs.
It was introduced in 2009 commit 0477a07.

@rousskov
Do not leak memory when reading FTP CWD responses
582262c 
The bug affected a subset of HTTP transactions with `ftp://` URLs. It
was introduced in 2009 commit 0477a07.
@rousskov rousskov changed the title y Do not leak memory when reading FTP CWD responses Jun 18, 2026
@rousskov rousskov added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Jun 18, 2026
yadij
yadij approved these changes Jun 19, 2026
View reviewed changes

@yadij yadij left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.

squid-anubis pushed a commit that referenced this pull request Jun 19, 2026
@rousskov @squid-anubis
Do not leak memory when reading FTP CWD responses (#2445)
cd3fa99 
The bug affected a subset of HTTP transactions with `ftp://` URLs. It
was introduced in 2009 commit 0477a07.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Jun 19, 2026
@rousskov rousskov removed M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) labels Jun 19, 2026
@rousskov

rousskov commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Something went wrong during the creation of the staged commit for this PR. I have removed M-cleared-for-merge label while @eduard-bagdasaryan is investigating.

@rousskov rousskov added the S-waiting-for-QA QA team action is needed (and usually required) label Jun 19, 2026
@squid-anubis squid-anubis added the M-abandoned-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Jun 19, 2026
@rousskov rousskov added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-waiting-for-QA QA team action is needed (and usually required) and removed S-waiting-for-QA QA team action is needed (and usually required) M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Jun 20, 2026
squid-anubis pushed a commit that referenced this pull request Jun 20, 2026
@rousskov @squid-anubis
Do not leak memory when reading FTP CWD responses (#2445)
acdf34e 
The bug affected a subset of HTTP transactions with `ftp://` URLs.
It was introduced in 2009 commit 0477a07.
@squid-anubis squid-anubis added M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-abandoned-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Jun 20, 2026
@rousskov rousskov added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-QA QA team action is needed (and usually required) labels Jun 20, 2026
@squid-anubis squid-anubis added M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels labels Jun 20, 2026
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinkie kinkie kinkie approved these changes

@yadij yadij yadij approved these changes

Assignees

No one assigned

Labels

M-failed-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-merged https://github.com/measurement-factory/anubis#pull-request-labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rousskov @kinkie @yadij @squid-anubis