[81reap]

Behavior does not change.

Refs #1056

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[lovasoa]

Is there a reason for the change? the old implementation sounds cleaner, doesn't it? we don't need to allocate an intermediary vector here

[81reap]

This is mostly a refactor to support the feature flagged dialup stratgey. Thread here :: #1597 (comment)

[lovasoa]

it looks like the refactor does not pay for itself in it's current form. It just creates an intermediary vec that's not needed

[81reap]

we can revert if you'd like, I don't mind waiting for more thoughts on this :)

creates an intermediary vec

jsut an opinion, but to me this is part of writing readable PRs. I want to take the intermediate fluff and refactors out of the meat and potatos so that we can make sure the important stuff is semantically correct

[lovasoa]

Yes, refactoring is welcome ! I did keep your extraction of the key-value logic into a separate function, but removed the unneeded allocation of an intermediary vector. 54a2320