Repository navigation
refactor(database) :: share connection setup between pools - #1594
Merged
Merged
Conversation
The two hook files were read by two copies of the same code. One function now reads both. Behaviour and log messages are unchanged. Refs #1056
lovasoa
force-pushed
the
81reap/sqlx-next/2-connection-setup
branch
from
November 12, 2026 09:48
4dca550 to
9606f49
Compare
lovasoa
requested changes
Nov 12, 2026
|
|
||
| struct ConnectionHooks { | ||
| on_connect: Option<Arc<String>>, | ||
| on_reset: Option<Arc<String>>, |
Collaborator
There was a problem hiding this comment.
just a nit, but Arc String is a double inspection, shouldn't this be an Arc str ?
lovasoa
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two hook files were read by two copies of the same code. One function now reads both. Behaviour and log messages are unchanged.
Refs #1056
Stack created with GitHub Stacks CLI • Give Feedback 💬