fix(codegen): no spurious lib/pq import for MySQL with sqlc.narg + sqlc.slice (#3783)

internal/codegen/golang/imports.go

@@ -376,7 +376,24 @@ func (i *importer) queryImports(filename string) fileImports {
 			}
 			if !q.Arg.isEmpty() {
 				if q.Arg.IsStruct() {
+					// A single named parameter referenced as both a regular
+					// argument (e.g. `sqlc.narg(x) IS NULL`) and as a
+					// `sqlc.slice('x')` produces two struct fields sharing
+					// the same name and type, but only the slice variant
+					// carries the IsSqlcSlice flag. The non-slice duplicate
+					// must not be counted as a `[]T` arg requiring lib/pq,
+					// because the generated code expands the slice in-place
+					// via `/*SLICE:...*/?` and never calls pq.Array on it.
+					sqlcSliceNames := map[string]struct{}{}
 					for _, f := range q.Arg.Struct.Fields {
+						if f.HasSqlcSlice() {
+							sqlcSliceNames[f.Name] = struct{}{}
+						}
+					}
+					for _, f := range q.Arg.Struct.Fields {
+						if _, ok := sqlcSliceNames[f.Name]; ok {
+							continue
+						}
 						if strings.HasPrefix(f.Type, "[]") && f.Type != "[]byte" && !f.HasSqlcSlice() {
 							return true
 						}

internal/endtoend/testdata/mysql_slice_narg_no_pq_3783/mysql/query.sql

@@ -0,0 +1,10 @@
+-- https://github.com/sqlc-dev/sqlc/issues/3783
+-- name: CausesPgToBeImported :many
+SELECT
+    id AS author_id,
+    name AS author_name,
+    bio AS author_bio
+FROM
+    authors
+WHERE
+    (sqlc.narg('author_ids') IS NULL OR id IN (sqlc.slice('author_ids')));

internal/endtoend/testdata/mysql_slice_narg_no_pq_3783/mysql/schema.sql

@@ -0,0 +1,5 @@
+CREATE TABLE authors (
+  id   BIGINT  NOT NULL AUTO_INCREMENT PRIMARY KEY,
+  name text    NOT NULL,
+  bio  text
+);

internal/endtoend/testdata/mysql_slice_narg_no_pq_3783/mysql/sqlc.json

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "engine": "mysql",
+      "path": "go",
+      "name": "querytest",
+      "schema": "schema.sql",
+      "queries": "query.sql"
+    }
+  ]
+}