Fix sign-in flow to properly cancel pending requests on user cancellation#960
Merged
Merged
Conversation
…tion Abort the pending sign-in request when the user cancels the dialog, instead of leaving it pending until the hard timeout expires, and scope the timeout ceiling to the system browser flow only, since the embedded browser already cancels correctly on its own. Normalize all sign-in cancellation paths (embedded/system browser MSAL cancellation, timeout, explicit user abort) to a single OperationCanceledException, handled by responding 204 No Content instead of an error, and remove the now-unused SignInMsalTimeoutExpired problem code and its telemetry noise across all locales.
albertospelta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abort the pending sign-in request when the user cancels the dialog, instead of leaving it pending until the hard timeout expires, and scope the timeout ceiling to the system browser flow only, since the embedded browser already cancels correctly on its own.
Normalize all sign-in cancellation paths (embedded/system browser MSAL cancellation, timeout, explicit user abort) to a single OperationCanceledException, handled by responding 204 No Content instead of an error, and remove the now-unused SignInMsalTimeoutExpired problem code and its telemetry noise across all locales.