Fix race condition on soc values in web ui#4059
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an SoC display inconsistency in the Web UI (suspected recurrence of issue #4016) by reducing the chance of readers observing partially-updated multi-inverter totals while fetch_inverter_data() is summing values.
Changes:
- Initialize additional inverter-related aggregate fields in
PredBat.reset()so they have safe defaults. - Refactor
Execute.fetch_inverter_data()to accumulate inverter totals in locals and only publish toself.*after the loop completes. - Avoid restoring
self.soc_kwinOutput.calculate_yesterday()(prevents overwriting newer SoC values from other update paths).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/predbat.py | Adds default initialization for additional reserve/limit aggregate fields during reset. |
| apps/predbat/output.py | Stops restoring self.soc_kw at the end of calculate_yesterday(). |
| apps/predbat/execute.py | Accumulates inverter totals in locals and publishes after the loop to reduce mid-sum races. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe root cause of: #4016