Wait for MQTT connection during gateway startup#4057
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GatewayMQTT component startup path to wait for the first MQTT connection attempt (success or failure) before declaring the component “started”, and adds focused unit tests to validate that wait behavior.
Changes:
- Add
_first_connection_attemptedstate and a bounded startup wait loop inGatewayMQTT.run(first=True). - Mark
_first_connection_attemptedon both successful connect and connection-error paths in_mqtt_loop. - Add new gateway startup-wait tests and bump PredBat version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/predbat/gateway.py | Adds first-connection-attempt tracking and a startup wait loop before returning success on the first run. |
| apps/predbat/tests/test_gateway.py | Adds TestRunStartupWait to validate the new startup wait/timeout behavior. |
| apps/predbat/predbat.py | Bumps THIS_VERSION to v8.40.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.