Use correct logger for user details configuration warning - #19637
Open
avsan wants to merge 1 commit into
Open
Conversation
Use the InitializeUserDetailsBeanManagerConfigurer logger category for the configuration warning so that the documented logger name matches the logger that emits the warning. Add regression coverage for the logger category. Closes spring-projectsgh-19595 Signed-off-by: avsan <abhishekrajabca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the
InitializeUserDetailsBeanManagerConfigurerlogger category forthe user details configuration warning.
The warning tells users to configure the logging level for
InitializeUserDetailsBeanManagerConfigurer, but the logger is currentlycreated from the inner
InitializeUserDetailsManagerConfigurerclass.As a result, the logger that emits the warning does not match the logger
category referenced by the warning message.
Changes
InitializeUserDetailsBeanManagerConfigurer.classwhen creatingthe logger.
the documented logger category.
Testing
warning was emitted from the inner configurer logger.
AuthenticationConfigurationTestspasses.:spring-security-config:checkFormatpasses.git diff --checkis clean.Closes gh-19595