Skip to content

Polish (Reactive)ClientRegistrationRepository #19604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ngocnhan-tran1996 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Polish (Reactive)ClientRegistrationRepository #19604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bf52cd
Prevent NPE in InMemoryClientRegistrationRepository
ngocnhan-tran1996 Aug 27, 2026
b285b77
Update Javadoc in ReactiveClientRegistrationRepository
ngocnhan-tran1996 Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...ngframework/security/oauth2/client/registration/InMemoryClientRegistrationRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,12 @@ public final class InMemoryClientRegistrationRepository
* @param registrations the client registration(s)
*/
public InMemoryClientRegistrationRepository(ClientRegistration... registrations) {
this(Arrays.asList(registrations));
this(toList(registrations));
}

private static List<ClientRegistration> toList(ClientRegistration... registrations) {
Assert.notEmpty(registrations, "registrations cannot be null or empty");
return Arrays.asList(registrations);
}

/**
Expand All @@ -69,6 +74,7 @@ private static Map<String, ClientRegistration> createRegistrationsMap(List<Clien
private static Map<String, ClientRegistration> toUnmodifiableConcurrentMap(List<ClientRegistration> registrations) {
ConcurrentHashMap<String, ClientRegistration> result = new ConcurrentHashMap<>();
for (ClientRegistration registration : registrations) {
Assert.notNull(registration, "no registration can be null");
Assert.state(!result.containsKey(registration.getRegistrationId()),
() -> String.format("Duplicate key %s", registration.getRegistrationId()));
result.put(registration.getRegistrationId(), registration);
Expand Down
4 changes: 2 additions & 2 deletions ...ork/security/oauth2/client/registration/InMemoryReactiveClientRegistrationRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@
import org.springframework.util.Assert;

/**
* A Reactive {@link ClientRegistrationRepository} that stores
* A {@link ReactiveClientRegistrationRepository} that stores
* {@link ClientRegistration}(s) in-memory.
*
* @author Rob Winch
* @author Ebert Toribio
* @since 5.1
* @see ClientRegistrationRepository
* @see ReactiveClientRegistrationRepository
* @see ClientRegistration
*/
public final class InMemoryReactiveClientRegistrationRepository
Expand Down
9 changes: 9 additions & 0 deletions ...mework/security/oauth2/client/registration/InMemoryClientRegistrationRepositoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,13 @@ public void iteratorWhenGetThenContainsAll() {
assertThat(this.clients).containsOnly(this.registration);
}

@Test
public void constructorWhenVarArgsThenIllegalArgumentException() {
assertThatIllegalArgumentException().isThrownBy(() -> new InMemoryClientRegistrationRepository());
assertThatIllegalArgumentException()
.isThrownBy(() -> new InMemoryClientRegistrationRepository((ClientRegistration[]) null));
assertThatIllegalArgumentException()
.isThrownBy(() -> new InMemoryClientRegistrationRepository((ClientRegistration) null));
}

}
Loading