GH-11275: Replace unnecessary fully-qualified type references with im… by ZaheerAhmadDev · Pull Request #11276 · spring-projects/spring-integration

ZaheerAhmadDev · 2026-08-16T09:16:10Z

Replaced fullyqualifiedtype referenced with import
It make code more readeable and consistant.
these violation found in:https://checkstyle-diff-reports.s3.us-east-2.amazonaws.com/4bb42ce_2026073849/reports/diff/spring-integration/index.html
Did fix some of the violation, most of the violation is java.lang.string we can import it, instead of using fullyqualified.

artembilan

@ZaheerAhmadDev ,

thank you for an update!
May we understand that this PR is going to fix the mentioned issue in full potential?
Or do you anticipate some phases?

ZaheerAhmadDev · 2026-08-16T13:07:22Z

Not likely, this PR is mostly to get real-world feedback and show the check has practical value it only fixes some part of the violations. Once the check is merged upstream, I can open a new PR to address the rest.
if that works for you.?

artembilan · 2026-08-16T13:14:03Z

Right. Why do we need a separate PR when everything can be addressed here?
More over we cannot separate check and its fix: the project is going to fail until we fix all of them .

ZaheerAhmadDev · 2026-08-16T13:17:35Z

Right. Why do we need a separate PR when everything can be addressed here? More over we cannot separate check and its fix: the project is going to fail until we fix all of them .

Make sense, lets fix all the violation in this PR.

ZaheerAhmadDev · 2026-08-16T14:38:37Z

Done fixed all the violations.
@artembilan, please take a look when you get a chance.

artembilan

Thanks, but I don’t see an addition to the Checkstyle.xml.
Or do you mean to fix classes first and apply check because there are so many of them?

artembilan · 2026-08-17T01:57:04Z

-import org.springframework.messaging.converter.GenericMessageConverter;
-import org.springframework.messaging.converter.JacksonJsonMessageConverter;
-import org.springframework.messaging.converter.MessageConverter;
+import org.springframework.messaging.converter.*;


No asterisk imports, please.
I think there is a respective Checkstyle rule 😁.

Done revert it.

I think there is a respective Checkstyle rule 😁.

avoidstarimport check does that :).

artembilan · 2026-08-17T01:57:53Z

 import org.springframework.beans.factory.InitializingBean;
 import org.springframework.core.convert.ConversionService;
 import org.springframework.core.convert.support.DefaultConversionService;
+import org.springframework.integration.support.json.Jackson2JsonObjectMapper;


I believe that this class is deprecated , therefor FQCN for it in the code, pkease

Done revert it back to FQCN.

artembilan · 2026-08-17T02:00:24Z

 import org.springframework.http.converter.feed.AtomFeedHttpMessageConverter;
 import org.springframework.http.converter.feed.RssChannelHttpMessageConverter;
 import org.springframework.http.converter.json.JacksonJsonHttpMessageConverter;
+import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter;


Done, now all deprecate revert back to FQCN.

artembilan · 2026-08-17T02:01:44Z

-import org.springframework.kafka.support.JacksonPresent;
-import org.springframework.kafka.support.JsonKafkaHeaderMapper;
-import org.springframework.kafka.support.KafkaHeaders;
+import org.springframework.kafka.support.*;


artembilan · 2026-08-17T02:05:24Z

 		else if (JacksonPresent.isJackson2Present()) {
 			MessagingMessageConverter messageConverter = new MessagingMessageConverter();
-			var headerMapper = new org.springframework.kafka.support.DefaultKafkaHeaderMapper();
+			var headerMapper = new DefaultKafkaHeaderMapper();


This one is deprecated.
I thought we discussed that with you to skip.
Maybe there is a way for Checkstyle to read a file for such a class usage and spot expected @Deprecated at the class name ?

I thought we discussed that with you to skip.

i did skip it but some of them have been missed now all deprecated are FQCN.

Maybe there is a way for Checkstyle to read a file for such a class usage and spot expected @deprecated at the class name ?

Suppressionxpath can supress it https://checkstyle.sourceforge.io/filters/suppressionxpathfilter.html .

artembilan · 2026-08-17T02:05:41Z

-import org.springframework.kafka.support.JacksonPresent;
-import org.springframework.kafka.support.JsonKafkaHeaderMapper;
-import org.springframework.kafka.support.KafkaHeaders;
+import org.springframework.kafka.support.*;


artembilan · 2026-08-17T02:05:54Z

 		}
 		else if (JacksonPresent.isJackson2Present()) {
-			var headerMapper = new org.springframework.kafka.support.DefaultKafkaHeaderMapper();
+			var headerMapper = new DefaultKafkaHeaderMapper();


Done revert it to FQCN.

artembilan · 2026-08-17T02:06:08Z

-import org.springframework.kafka.support.KafkaUtils;
-import org.springframework.kafka.support.LogIfLevelEnabled;
-import org.springframework.kafka.support.TopicPartitionOffset;
+import org.springframework.kafka.support.*;


artembilan · 2026-08-17T02:06:18Z

 		}
 		else if (JacksonPresent.isJackson2Present()) {
-			var headerMapper = new org.springframework.kafka.support.DefaultKafkaHeaderMapper();
+			var headerMapper = new DefaultKafkaHeaderMapper();


Done revert it to fullyqualified.

…erences with imports Signed-off-by: ZaheerAhmadDev <zk7386048@gmail.com>

ZaheerAhmadDev · 2026-08-17T08:16:10Z

Thanks, but I don’t see an addition to the Checkstyle.xml. Or do you mean to fix classes first and apply check because there are so many of them?

currently check is not yet released it is in review, when we release it with new release, i will add it to then with followup pr.
if we add it now it will gonna show error of not found.
i did fix all of the violation excluding AvroTestClass and deprecated classes, as there is suppression for AvroTestClass in checkstyle-suppression.xml which will exclude this check automatically also but we need to add suppression for deprecated classes will gonna added it when we add check in checkstyle.xml when Checkstyle releases the check,
in a follow up pr.

ZaheerAhmadDev force-pushed the GH-11275 branch 2 times, most recently from 7e14f69 to 6d2030a Compare August 16, 2026 12:33

artembilan requested changes Aug 16, 2026

View reviewed changes

ZaheerAhmadDev force-pushed the GH-11275 branch from 6d2030a to c7e4272 Compare August 16, 2026 14:25

ZaheerAhmadDev requested a review from artembilan August 16, 2026 14:38

ZaheerAhmadDev force-pushed the GH-11275 branch from c7e4272 to fa6c781 Compare August 17, 2026 01:52

artembilan requested changes Aug 17, 2026

View reviewed changes

spring-projectsGH-11275: Replace unnecessary fully-qualified type ref…

1f3f24f

…erences with imports Signed-off-by: ZaheerAhmadDev <zk7386048@gmail.com>

ZaheerAhmadDev force-pushed the GH-11275 branch from fa6c781 to 1f3f24f Compare August 17, 2026 07:52

ZaheerAhmadDev requested a review from artembilan August 18, 2026 05:56

Uh oh!

Conversation

ZaheerAhmadDev commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

artembilan left a comment

Choose a reason for hiding this comment

Uh oh!

ZaheerAhmadDev commented Aug 16, 2026

Uh oh!

artembilan commented Aug 16, 2026

Uh oh!

ZaheerAhmadDev commented Aug 16, 2026

Uh oh!

ZaheerAhmadDev commented Aug 16, 2026

Uh oh!

artembilan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZaheerAhmadDev commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ZaheerAhmadDev commented Aug 16, 2026 •

edited

Loading

ZaheerAhmadDev commented Aug 17, 2026 •

edited

Loading