Repository navigation
Conversation
EnvironmentChangeListener applied every EnvironmentChangeRemoteApplicationEvent
it saw. Events published by the busenv endpoint are also delivered to local
listeners, so POST /actuator/busenv/{destination} changed the environment of
the instance that received the request even when the destination was another
service.
RefreshListener and ShutdownListener already check ServiceMatcher#isForSelf
for the same reason (spring-cloud-bus#68). Do the same here.
Signed-off-by: kdelay <kdelay20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /actuator/busenv/{destination}changes the environment of the instance that received the request even when the destination is another service. The endpoint publishes the event locally, andEnvironmentChangeListenerapplies it without checking the destination.RefreshListenerandShutdownListeneralready checkServiceMatcher#isForSelffor this (spring-cloud-bus#68, #221). This adds the same check toEnvironmentChangeListener.The new
EnvironmentChangeListenerIntegrationTestsfails without the change (expected: null but was: "changed"for ademoappdestination on afoobarapp)../mvnw -pl bus/spring-cloud-bus verifypasses, 77 tests.