Repository navigation
Conversation
zephyr45
force-pushed
the
issue-3764-instance-method-suppliers
branch
from
October 6, 2026 18:27
9805b5e to
c707583
Compare
Retain supplier bean instances as reflective operation targets so custom predicates and filters can use injected dependencies while static DSL methods continue to work. Fixes spring-cloudgh-3764 Signed-off-by: zephyr45 <anuraaagsingh.45@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follows the bean-plus-method technique used by Spring MVC handler mappings while retaining Gateway's existing argument conversion and external-configuration invoker.
Verification
./mvnw -pl spring-cloud-gateway-server-webmvc -am -Dtest=FilterDiscovererTests,FilterBeanFactoryDiscovererTests,PredicateDiscovererTests,PredicateBeanFactoryDiscovererTests -Dsurefire.failIfNoSpecifiedTests=false test— 4 tests passed; Checkstyle reported 0 violations./mvnw -pl spring-cloud-gateway-server-webmvc -am test— 217 tests ran with 0 assertion failures; 105 Testcontainers errors because no Docker daemon is available locallyFixes gh-3764