Repository navigation
Conversation
WEIZIBIN
force-pushed
the
bugfix_cache_request_body_buf_release
branch
from
January 14, 2022 06:14
7ad6ecf to
f8a2f25
Compare
WEIZIBIN
changed the title
Contributor
|
It seems ServerWebExchangeUtils.CACHED_REQUEST_BODY_ATTR, previously used in pair (ReadBodyRoutePredicateFactory, AdaptCachedBodyGlobalFilter) also is used in CacheRequestBodyFilter after #1943. |
nkonev
approved these changes
Jan 21, 2022
|
Stuck by the same bug, any progress? |
Member
|
Is this still an issue? |
WEIZIBIN
force-pushed
the
bugfix_cache_request_body_buf_release
branch
from
October 8, 2026 05:51
f8a2f25 to
9e32410
Compare
Contributor
Author
|
Closing in favor of #2842 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now
CacheRequestBodyFilter sets the object ServerWebExchangeUtils.CACHED_REQUEST_BODY_ATTR but cover the previous DataBuffer, and then RemoveCachedBodyFilter loses the reference to the DataBuffer, not releasing the DataBuffer, causing direct memory leaks
after
CacheRequestBodyFilter sets the object to ServerWebExchangeUtils.CACHED_REQUEST_BODY_OBJECT_ATTR that attribute reuse from ReadBodyRoutePredicateFactory
The is essentially a breaking change.