Repository navigation
Conversation
lpmi-13
commented
Nov 12, 2026
| with: | ||
| persist-credentials: false | ||
| - uses: ./.github/actions/setup-sdk-environment | ||
| - uses: $/.github/actions/setup-sdk-environment |
Author
There was a problem hiding this comment.
this is to documented way to refer to local actions:
https://github.com/github/gh-actions-lock#limitations
Collaborator
There was a problem hiding this comment.
Yeah found out about this recently when running zizmor on some of our repos. The syntax does indeed work, but clankers desperately flag this as wrong despite noting down otherwise in AGENTS.md. We don't use LLMs here much, but non-maintainers will definitely bring this up thinking it's a mistake. Alas, we might need to leave this in for now just to spare ourselves the unnecessary busywork. :(
Collaborator
|
Oooh didn't know about this yet, we'll have a look! <3 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add in a github actions lockfile that asserts the actual owner of the referenced actions (just sha pinning doesn't do that and will resolve sha hashes from forks: https://www.vaines.org/posts/2026-03-24-the-comforting-lie-of-sha-pinning/).
https://github.blog/changelog/2026-10-28-github-actions-workflow-lockfiles-are-generally-available/