Repository navigation
gate: no commit by a test identity, and spinpropose writes no git config - #33
Merged
Merged
Conversation
A test in spin wrote git's author into the checkout's config, and every commit after it was the test's, on GitHub. The gate now runs go-tools' testidentity over the branch's commits since origin/main - a reserved-domain address, one with no dot, or one this tree's tests spell - so such a commit stops here. CI's Gate fetches the history it reads. spinpropose set the app's name and address with git config, on the checkout it ran in: every commit made there after it was the app's. It commits as the app with -c on that commit alone, and its test holds that no git config is run. Its tests run no git: every command goes to the fake. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to spin-stack/spin#1196 and spin-stack/go-tools#104. A test in spin wrote
ana@corp.exampleinto a checkout's.git/config, and every commit made after that carried it to GitHub.task gaterunstestidentity -base origin/main, whichgo tool taskputs on PATH from go-tools' latest release (v20261113.01). It fails on a commit since main whose raw author or committer address is at a reserved domain, has no dot, or appears in this tree's tests or fixtures. The failure says how to fix it. GitHub's noreply and bot addresses pass.fetch-depth: 0so origin/main is in the clone on a pull request.hack/spinpropose. Its test runs no git, because every command goes to the fake. The code it tests did rungit config user.name/user.emailon whatever checkout it ran in, though, which makes every later commit there the app's. It now commits as the app with-con that one commit, and the test asserts that nogit configis run.Checked:
go tool task gatepasses, andgo test ./hack/...passes.🤖 Generated with Claude Code