Repository navigation
image: no hot-add rule for memory, which the kernel onlines itself - #238
Merged
Merged
Conversation
memhp_default_state=online is always on the command line (machine/cmdline.go), so the kernel onlines every virtio-mem block itself. The block's add uevent leaves before that, udev read it offline and wrote "online" after the kernel had, and udevd logged an EINVAL failure for every block a workspace grew by. The CPU line stays: nothing else onlines a hot-added core. Closes #230 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #230
A workspace that grew through virtio-mem logged, for every block,
40-spin-hotadd.rules:23 ATTR{state}="online": Failed to write "online" ... Invalid argument. The kernel onlines each hot-added block itself -memhp_default_state=onlineis on every command line (machine/cmdline.go:138, unconditional) - and a block's add event goes out before that step, so udev's write arrived after the kernel's andstate_storeanswered EINVAL for a block already online. No memory was lost; the console filled with false failures.The memory line goes; the CPU line stays, with a comment saying why memory has no rule. spin names the rule only for CPUs (checked: AGENTS.md, vmm, hotplug/cpu, handoff, the image integration test's
SUBSYSTEM=="cpu"check).task lintandtask testpass. Not built into an image nor booted here; the repository has no boot test that grows memory through virtio-mem, so the issue's "udevd logged no failure" check has nowhere to go yet.🤖 Generated with Claude Code