Repository navigation
dependabot: @types/node follows the Node the tests run on, by hand - #16
Merged
Merged
Conversation
#14 proposed @types/node 26. The tests run on Node 22 and VS Code's extension host on 24, so types of 26 typecheck calls neither has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14 proposes
@types/node22 → 26. The tests run on Node 22 (setup-nodein ci.yml and publish.yml), and VS Code 1.146's extension host on Node 24.22 (Electron 43.8, checked withELECTRON_RUN_AS_NODE=1 code -p process.versions). Types of 26 would typecheck calls that neither runtime has.This ignores semver-major updates of
@types/nodeonly. Minor and patch updates still come in thejsgroup. A major moves by hand, together withnode-version. #14 gets closed in favour of this.🤖 Generated with Claude Code