Repository navigation
palette: a chart's series and statuses, one set held on both pages - #29
Merged
Merged
Conversation
The installation's Grafana dashboards drew in Grafana's classic palette: no colour in them was the brand's, because the brand had none for a chart. A dashboard is one JSON drawn in whichever theme the viewer chose, so [chart] is one set for both modes: eight series in a fixed order (the mark's blue first) and the three steps a threshold climbs through. Each holds 3:1 as a line on dark's page and on light's, each series is apart from the next and each status from the others at the meaning tier, in every view. tokens.json carries them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installation's Grafana dashboards (spin's
internal/controlplane/grafana) draw in Grafana's classic palette: the brand has no colour for a chart, so none of theirs is the brand's. This adds one.[chart]inpalette.toml, written totokens.jsonaschart:series#2F6BE3) first, then orange, teal, ochre, magenta, green, violet, red. A ninth series folds into "other", never a generated huegood,warning,criticalOne set for both modes. A Grafana dashboard is one JSON drawn in whichever theme the viewer picked (spin's Metrics page passes the page's theme), and a colour in it is one hex. So every chart colour sits in the middle lightness band:
#111827and on light's#FFFFFF. The lowest is teal on white, 3.32:1.meaningtier: ΔE00 20 as drawn and 10 in the worst view. The worst series pair is ochre/magenta under tritanopia at 11.6. The worst status pair is good/warning under protan on the IPS panel at 10.5.The method came from a categorical-palette validator: lightness band, chroma floor, adjacent-pair CVD separation and a normal-vision floor. It passed in both modes before
cmd/palettechecked it here.Proved the check can fail: with series 2 set to the cyan
#27BFE8,go run ./cmd/palette -checkreportsFAIL light non-text series 2 on page 2.16:1 (floor 3.0)and exits 1.dist/dashboard.css,tokens.css,starlight.cssandlogos/do not change. Onlytokens.json(andperception.js, the preview's list of pairs) do.Consumer: spin's Grafana dashboards, in a PR that copies
tokens.jsonat this commit and holds every colour in the dashboards to it.🤖 Generated with Claude Code