fix(azad-text): stop number conversion from mangling ordinary speech#3
Open
Montana wants to merge 1 commit into
Open
fix(azad-text): stop number conversion from mangling ordinary speech#3Montana wants to merge 1 commit into
Montana wants to merge 1 commit into
Conversation
- Digit sequences are cardinal-only, so ordinals are no longer consumed:
'give me one second' no longer becomes 'give me 1 2'. Ordinals still
combine into cardinals ('twenty fourth' -> 24).
- Plural scale words stay verbatim: 'hundreds of people' no longer
becomes '100 of people' (generalizes the existing 'seconds' carve-out).
- Number candidates ending in 'and' are rejected so the connective
survives: 'between five and six' no longer becomes 'between 5 six'.
Interior 'and' still parses ('two hundred and sixty six' -> 266).
Adds regression tests for all three cases; each fails on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @spence,
Adds regression tests for all three cases; each fails on main.
Cheers,
Michael