Repository navigation
fix(database): unify PostgreSQL selection with legacy indexing connections - #72
Merged
Merged
Conversation
…tions - Implement PostgresConnectionAdapter and DictRow in connection.py for PostgreSQL relational database selection - Ensure get_db_connection() never creates or queries fallback SQLite database when PostgreSQL is selected - Standardize INSERT OR REPLACE INTO queries to standard ON CONFLICT(...) DO UPDATE SET across credentials, embedding_cache, git_syncer, and local_syncer - Update column migration check functions for PostgreSQL information_schema compatibility - Document schema migration, database selection, and rollback procedures in DEVELOPER_DOCS.md - Add comprehensive test suite in tests/test_postgres_unified_connection.py Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…tions - Implement PostgresConnectionAdapter and DictRow in connection.py for PostgreSQL relational database selection - Ensure get_db_connection() never creates or queries fallback SQLite database when PostgreSQL is selected - Standardize INSERT OR REPLACE INTO queries to standard ON CONFLICT(...) DO UPDATE SET across credentials, embedding_cache, git_syncer, and local_syncer - Update column migration check functions for PostgreSQL information_schema compatibility - Configure asyncio_default_fixture_loop_scope in pytest.ini for CI pytest runs - Document schema migration, database selection, and rollback procedures in DEVELOPER_DOCS.md - Add comprehensive test suite in tests/test_postgres_unified_connection.py Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Owner
Author
|
@jules Please review and address the following items for this PR: Issues to Fix
How to Confirm the FixRun the following commands to confirm everything passes: wc -l app/services/database/connection.py app/services/database/postgres_compat.py
pytest tests/test_postgres_unified_connection.py -v
python3 scripts/generate_requirements.py
pytest tests/backend/test_requirements_sync.py |
…tions - Implement PostgresConnectionAdapter and DictRow in connection.py for PostgreSQL relational database selection - Ensure get_db_connection() never creates or queries fallback SQLite database when PostgreSQL is selected - Standardize INSERT OR REPLACE INTO queries to standard ON CONFLICT(...) DO UPDATE SET across credentials, embedding_cache, git_syncer, and local_syncer - Update column migration check functions for PostgreSQL information_schema compatibility - Configure asyncio_default_fixture_loop_scope in pytest.ini for CI pytest runs - Document schema migration, database selection, and rollback procedures in DEVELOPER_DOCS.md - Add comprehensive test suite in tests/test_postgres_unified_connection.py Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…e architecture rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unifies PostgreSQL relational database selection with legacy indexing, repository, setting, credential, ADR, search, and file deletion paths via PostgresConnectionAdapter. Replaces SQLite-specific statements with ANSI SQL ON CONFLICT DO UPDATE SET, asserts no fallback SQLite files are created under PostgreSQL, and documents migration/rollback procedures.
Fixes #45
PR created automatically by Jules for task 15709480853732629288 started by @spelech