Repository navigation
fix(vector-store): fail remote connection tests on unreachable endpoints - #71
Merged
Merged
Conversation
- Prevent automatic local fallback in Qdrant and Chroma vector stores when explicit remote targets fail, unless opt-in allow_fallback=True is passed. - Report configured_mode, effective_mode, fallback_active, and fallback_reason in vector store stats, config, and health checks. - Return explicit error messages on POST /admin/api/vector-store/test when remote Qdrant or Chroma endpoints cannot be reached. - Add test coverage for remote connection failures and opt-in degraded fallbacks. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Prevent automatic local fallback in Qdrant and Chroma vector stores when explicit remote targets fail, unless opt-in allow_fallback=True is passed. - Report configured_mode, effective_mode, fallback_active, and fallback_reason in vector store stats, config, and health checks. - Return explicit error messages on POST /admin/api/vector-store/test when remote Qdrant or Chroma endpoints cannot be reached. - Add test coverage for remote connection failures and opt-in degraded fallbacks. - Ignore deprecation warnings for asyncio_default_fixture_loop_scope in pytest.ini. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Owner
Author
|
@jules Please review and address the following items for this PR: Issues to Fix
How to Confirm the FixRun the following commands to confirm everything passes: pytest tests/backend/test_api_vector_store.py tests/backend/test_vector_store_chroma.py tests/backend/test_vector_store_qdrant.py -v
python3 scripts/generate_requirements.py
pytest tests/backend/test_requirements_sync.py |
- Prevent automatic local fallback in Qdrant and Chroma vector stores when explicit remote targets fail, unless opt-in allow_fallback=True is passed. - Report configured_mode, effective_mode, fallback_active, and fallback_reason in vector store stats, config, and health checks. - Return explicit error messages on POST /admin/api/vector-store/test when remote Qdrant or Chroma endpoints cannot be reached. - Add test coverage for remote connection failures and opt-in degraded fallbacks. - Configure pytest.ini asyncio_mode and filterwarnings to prevent deprecation warning failures. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes vector store remote connection testing and backend initialization so that unreachable remote Qdrant or Chroma endpoints fail connection tests instead of validating silent local disk fallbacks. Remote fallback is now strictly opt-in, and configured vs effective modes are tracked and reported separately.
Fixes #59
PR created automatically by Jules for task 3622095910500824187 started by @spelech