Skip to content

fix(auth): enforce role permissions on REST storage and settings mutations - #70

Merged
spelech merged 4 commits into
mainfrom
fix/auth-rest-role-permissions-859311619347304834
Oct 28, 2026
Merged

spelech merged 4 commits into
mainfrom
fix/auth-rest-role-permissions-859311619347304834

Conversation

@spelech

@spelech spelech commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Enforce explicit least-privilege role permissions across all REST API endpoints (storage, settings, repositories, files, ingestion, graph, navigator). Viewer keys are restricted to read operations, editor keys can mutate storage content and trigger syncs, and admin keys manage settings, credentials, vector-store backend, and repository configurations. Added role-matrix regression tests in tests/test_rest_role_permissions.py.

Fixes #60


PR created automatically by Jules for task 859311619347304834 started by @spelech

…tions

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…tions

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@spelech

spelech commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

@jules Please review and address the following items for this PR:

Issues to Fix

  1. CRITICAL GIT HYGIENE - Remove Committed Coverage Artifact:
    • A large 8,336-line coverage file coverage/python-coverage.xml was accidentally committed to git in this PR.
    • Run git rm coverage/python-coverage.xml, ensure coverage/ is in .gitignore, and commit this cleanup.
  2. Requirement Traceability:
    • Tag RBAC test cases in tests/test_rest_role_permissions.py with @pytest.mark.requirement("AUTH-RBAC-01").
    • Re-sync docs/REQUIREMENTS.md.

How to Confirm the Fix

Run the following commands to confirm everything passes:

git rm coverage/python-coverage.xml
pytest tests/test_rest_role_permissions.py -v
python3 scripts/generate_requirements.py
pytest tests/backend/test_requirements_sync.py

spelech and others added 2 commits October 28, 2026 01:57
…tions

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@spelech
spelech merged commit 059a243 into main Oct 28, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(auth): enforce role permissions on REST storage and settings mutations

1 participant