Repository navigation
Require explicit opt-in and compatible model for local-to-API embedding fallback - #68
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…lback Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
@jules Please review and address the following items for this PR: Issues to Fix
How to Confirm the FixRun the following commands to confirm everything passes: pytest tests/backend/test_indexer_and_embeddings.py -v
python3 scripts/generate_requirements.py
pytest tests/backend/test_requirements_sync.py |
…lback Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
| } | ||
| except ValueError as ve: | ||
| logger.warning(f"Validation error updating embedding settings: {ve}") | ||
| return JSONResponse(status_code=400, content={"status": "error", "error": str(ve), "message": str(ve)}) |
Require explicit opt-in (
allow_fallback) and a compatible API model (fallback_dense_model) before falling back from local FastEmbed to API embeddings. If fallback is not explicitly enabled, local FastEmbed initialization failure raises a visible error and remains in local mode without making outbound API requests. Track requested vs. effective provider and dense model in system configuration metadata and response schemas.Fixes #52
PR created automatically by Jules for task 10830566446682326892 started by @spelech