Repository navigation
fix(credentials): surface host-list query failures instead of returning empty success - #67
Conversation
…ng empty success Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
@jules Please review and address the following items for this PR: Issues to Fix
How to Confirm the FixRun the following commands to confirm everything passes: pytest tests/backend/test_multi_git_providers.py -v
python3 scripts/generate_requirements.py
pytest tests/backend/test_requirements_sync.py |
…ng empty success Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Propagate credential-store query failures in list_git_host_credentials() so that API requests to GET /admin/api/settings/hosts return an HTTP 500 error instead of an empty success list ([]). Add safe handling in MCP status reporting and comprehensive tests covering empty success, query error, and credential masking.
Fixes #48
PR created automatically by Jules for task 747490283276708533 started by @spelech