Skip to content

fix(credentials): surface host-list query failures instead of returning empty success - #67

Merged
spelech merged 3 commits into
mainfrom
fix-host-list-query-failure-747490283276708533
Oct 28, 2026
Merged

spelech merged 3 commits into
mainfrom
fix-host-list-query-failure-747490283276708533

Conversation

@spelech

@spelech spelech commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Propagate credential-store query failures in list_git_host_credentials() so that API requests to GET /admin/api/settings/hosts return an HTTP 500 error instead of an empty success list ([]). Add safe handling in MCP status reporting and comprehensive tests covering empty success, query error, and credential masking.

Fixes #48


PR created automatically by Jules for task 747490283276708533 started by @spelech

…ng empty success

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@spelech

spelech commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

@jules Please review and address the following items for this PR:

Issues to Fix

  1. Accurate Error Reporting for Vault Query Failures:
    • In app/mcp/handlers/repo_handlers.py:106, when list_git_host_credentials() raises an exception, the handler reports 0 credentials. Instead, report - Git Host Credentials in Vault: [Unavailable - Query Failed] so operators can differentiate between zero credentials and an authentication/connection failure.
  2. Requirement Traceability:
    • Tag test cases in tests/backend/test_multi_git_providers.py with @pytest.mark.requirement("AUTH-VAULT-01").
    • Re-run python3 scripts/generate_requirements.py.

How to Confirm the Fix

Run the following commands to confirm everything passes:

pytest tests/backend/test_multi_git_providers.py -v
python3 scripts/generate_requirements.py
pytest tests/backend/test_requirements_sync.py

spelech and others added 2 commits October 28, 2026 01:55
…ng empty success

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@spelech
spelech merged commit be094c7 into main Oct 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(credentials): surface host-list query failures instead of returning an empty success

1 participant