gitleaksignore: allowlist Percona MongoDB placeholders in nvidia-nvsentinel-v1.19.0 - #309
Closed
vishwanaths wants to merge 1 commit into
Closed
gitleaksignore: allowlist Percona MongoDB placeholders in nvidia-nvsentinel-v1.19.0#309vishwanaths wants to merge 1 commit into
vishwanaths wants to merge 1 commit into
Conversation
…ers in nvidia-nvsentinel-v1.19.0 Add two fingerprints for the bundled psmdb-db chart's values.yaml. Both are commented-out AWS S3/KMS backup config placeholders shipped by Percona: line 675: kmsKeyID: 1234abcd-12ab-34cd-56ef-1234567890ab line 678: sseCustomerKey: Y3VzdG9tZXIta2V5 (base64 for "customer-key") Both are inert documentation examples inside upstream Percona chart defaults and were flagged by the generic-api-key rule. Unblocks the BulwarkGitLeaks check on #303.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two fingerprints to
.gitleaksignorefor the bundled Percona MongoDB (psmdb-db) chart'svalues.yamlinpacks/nvidia-nvsentinel-v1.19.0/. Both are commented-out AWS S3/KMS backup config placeholders shipped by Percona upstream:They are inert documentation examples inside upstream chart defaults and get flagged by the
generic-api-keyrule — false positives.Unblocks the BulwarkGitLeaks check on #303.
Test plan