Skip to content

feat(attachments): add attachment mapping file support#8008

Draft
grantfitzsimmons wants to merge 6 commits into
mainfrom
issue-4766-redux
Draft

feat(attachments): add attachment mapping file support#8008
grantfitzsimmons wants to merge 6 commits into
mainfrom
issue-4766-redux

Conversation

@grantfitzsimmons

Copy link
Copy Markdown
Member

Fixes #4766

Realized that previously implemented logic covered most of the cases. We already supported matching files to previously selected files. So, now, we just make a new attachment dataset based on the selected csv. When user selects files, they will be matched to this dataset (which is based on csv) so we just preserve the parsed name.

I'll add more automated tests for this before making this open for review for everything seems to be working!

EDIT: I based it off @melton-jason coge-import because I realized I could reuse some of that code. I'm still considering directly using workbench's implementation though

image

image

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR
  • Add migration function to
    def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

@github-project-automation github-project-automation Bot moved this to 📋Back Log in General Tester Board Apr 21, 2026
@grantfitzsimmons grantfitzsimmons changed the title Issue 4766 redux feat(attachments): add attachment mapping file support Apr 21, 2026
Now this trims filename and parsed name values when importing mapping CSVs to avoid leading/trailing whitespace and undefined values. Adds a bunch of tests!
@grantfitzsimmons grantfitzsimmons added this to the 7.16.0 milestone Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: eb6cf67e-61b7-473f-888a-d4cfb8b0dd19

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-4766-redux

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Add Attachment Mapping File support

2 participants