Skip to content

Unpin from requests 2.21.0#36

Open
kakoma wants to merge 1 commit into
sparkplug:masterfrom
kakoma:patch-1
Open

Unpin from requests 2.21.0#36
kakoma wants to merge 1 commit into
sparkplug:masterfrom
kakoma:patch-1

Conversation

@kakoma

@kakoma kakoma commented Oct 13, 2022

Copy link
Copy Markdown

Version 2.21.0 was released in 2018. Pinning the package to it creates dependency issues since other packages, such as urllib3, can't be updated past a certain version due to this constraint.

This PR opens this up to 2.2x since that picks newer versions but also steers clear of major updates. As of this writing, the latest version is 2.28.1

@raybesiga

Copy link
Copy Markdown
Member

Excellent submission @kakoma a few issues from the CI report. Valid? CC @mossplix

Screenshot 2022-10-13 at 11 19 54

@kakoma

kakoma commented Oct 20, 2022

Copy link
Copy Markdown
Author

@raybesiga Thanks. I see this in the failure log:

src/mtnmomo/collection.py:56: in requestToPay
    "Ocp-Apim-Subscription-Key": super(Collection, self).config.collectionsKey
src/mtnmomo/config.py:80: in collectionsKey
    "COLLECTION_PRIMARY_KEY is missing in the configuration")

Haven't follow-through to see what's at the root of this but maybe the team might see something immediately, just looking at it? I'm not able to dig further into it at this point unfortunately

@raybesiga

Copy link
Copy Markdown
Member

We no longer maintain this library but will see if I can get the requisite support in due course @kakoma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants