chore(rust): fix clippy warnings in splat sorting functions#370
Open
mmjinglin163 wants to merge 1 commit into
Open
chore(rust): fix clippy warnings in splat sorting functions#370mmjinglin163 wants to merge 1 commit into
mmjinglin163 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the PR, the changes look good for the most part. Personally I think the elimination of the let binding for Though if we're going to use clippy, I'd rather see it integrated and enforced (similar to TS linting through biome). Otherwise we'd end up with having to play catch-up with PRs every time changes to the Rust code introduces new linter warnings. @asundqui any preference in this matter? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(rust): fix clippy warnings in splat sorting functions