gitindex: report cat-file process failures - #1161
Open
keegancsmith wants to merge 1 commit into
Open
Conversation
Premature stdout EOFs currently lose the child exit status and stderr, making batch-reader failures look like ordinary EOF. Preserve those diagnostics while leaving fallback policy unchanged. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a06b86-7fd2-72fb-87a7-4cc8658d3db4
Member
Author
|
@clemlesne GitHub would not let me request your review as an outside contributor, but since you originally implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catfileReadercurrently treats a closed stdout pipe as ordinary EOF, losing the exit status and stderr whengit cat-filefails.Capture stderr and wait for the process when a stream read reaches EOF. If Git exited unsuccessfully, return its wrapped exit error and diagnostics; otherwise preserve normal EOF behavior.
sync.Oncelets EOF handling andClosesafely share the single process wait.This intentionally adds no fallback behavior; unsupported
--filteris already handled by the capability probe added in #1094.