fix: make macOS release builds work on Apple Silicon - #258
Merged
Conversation
Before this change, the macOS release job failed on the arm64 runner: ``` clang: error: include path for libstdc++ headers not found [-Werror,-Wstdlibcxx-not-found] ``` After this change, we unblock release jobs: release-mac builds for the host architecture instead, so that macOS release artifacts are genuinely arm64 (as the README and gem names claim, despite previously incorrectly being x86_64 binaries.) toolchains_llvm is patched with a backport of upstream PR 686 (released in v1.7.0) that drops `-L<toolchain>/lib` on macOS; we can remove this patch when we upgrade later. Verified locally on arm64: `release-mac` and `dev` builds of `//main:scip-ruby` succeed, the release binary is arm64 with only system dylib deps, and `//gems/scip-ruby` produces both `arm64-darwin` gems. Signed-off-by: Emi <emi@sourcegraph.com>
eseliger
approved these changes
Sep 3, 2026
eseliger
left a comment
eseliger
left a comment
Member
There was a problem hiding this comment.
gotta love bazel for its patching stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the macOS release job failed on the arm64 runner https://github.com/sourcegraph/scip-ruby/actions/runs/33796326759/job/100784771452:
After this change, we unblock release jobs: release-mac builds for the host architecture instead, so that macOS release artifacts are genuinely arm64 (as the README and gem names claim, despite previously incorrectly being x86_64 binaries.) toolchains_llvm is patched with a backport of upstream PR 686 (released in v1.7.0) that drops
-L<toolchain>/libon macOS; we can remove this patch when we upgrade later.Motivation
Need to release v0.4.8 #255
Test plan
Verified locally on arm64:
release-macanddevbuilds of//main:scip-rubysucceed, the release binary is arm64 with only system dylib deps, and//gems/scip-rubyproduces botharm64-darwingems.