fix: skip SCIP generation of occurrences with empty locations - #254
Open
emidoots wants to merge 2 commits into
Open
fix: skip SCIP generation of occurrences with empty locations#254emidoots wants to merge 2 commits into
emidoots wants to merge 2 commits into
Conversation
…Loc.empty()" segfault Signed-off-by: Emi <emi@sourcegraph.com>
Sorbet can assign empty locations to synthesized AST nodes, including Minitest `before` hooks inside `test_each`. Passing these locations to `trimColonColonPrefix` triggers an assertion in debug builds and can segfault in release builds as we've seen in production. Skip definitions and references with empty locations before converting them to SCIP ranges, and add a regression test for the Minitest case. Signed-off-by: Emi <emi@sourcegraph.com>
jasonhawkharris
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In prod we observed a segfault / failing assertion
SCIPIndexer.cc:122 enforced condition !baseLoc.empty(); this PR fixes that:Sorbet can assign empty locations to synthesized AST nodes, including Minitest
beforehooks insidetest_each. Passing these locations totrimColonColonPrefixtriggers an assertion in debug builds and can segfault in release builds as we've seen in prod.This PR fixes it by skipping definitions and references with empty locations before converting them to SCIP ranges.
Test plan
The first commit of this PR adds a regression test which fails with the same error seen in prod, the second commit fixes it.
I also did a basic index of
Homebrew/brewandstripe/stripe-rubyrepositories, and both resulting SCIP indexes appear valid.